-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version v10.11.0 RC #13706
Merged
Merged
Version v10.11.0 RC #13706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The form used for creating a vault on the "Import" page of onboarding and on the "Restore vault" page is nearly identical, yet the implementation is totally separate. It has now been extracted to a separate component, consolidating the two implementations. There is a "terms of use" checkbox on the import page that isn't on the restore vault page, so that part has been made optional. The "submit" button text differs between the two uses as well, so that is customizable. There are slight styling differences between the old and new versions of this form. The fonts and spacing are all using our new standard design system guidelines, and we're using our standard checkbox now as well. The spacing and font sizes were chosen somewhat arbitrarily by me to resemble the old styles, so please feel free to suggest changes if you think they can be improved upon. There are some slight copy changes to the "Restore vault" page as well; the placeholder text and the label for the "Secret Recovery Phrase" field now matches the "Import" page copy.
* Update personal-sign.spec.js * Update signature-request.spec.js * Add tests for eth_signTypedData and eth_signTypedData_v3 methods * Lint * Verify message * Verify message * Add test for eth_sign method
* validate ticker symbol in add/edit network form
* Add metamaskbot GH_USERNAME and GH_EMAIL to env * add additional config for token, github_user_name, github_user_email * delete * delete token * add GITHUB_ACTOR Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
… address' in permissions/specifications (#13521) * captureKeyringTypesWithMissingIdentities() when 'Missing identity for address' in permissions/specifications * Fix unit tests
* updated settings page removed unused messages fixed width moved icons into one folder review comments update removed unused strings renamed components removed class added prop updated e2e test e2e extracted icons * locales fix * update * margin-inline
* Do not call `decimalToHex` for `minimumGasLimit`, which is already in hex * Add `0x` prefix when returning a gas estimate * Fix UTs Co-authored-by: Dan J Miller <danjm.com@gmail.com>
* update test-dapp to 5.0.0 * Update edit-gas-fee.spec.js * Lint * Update send-eth.spec.js * Update signature-request.spec.js * typo Co-authored-by: PeterYinusa <peter.yinusa@consensys.net> Co-authored-by: Alex Donesky <adonesky@gmail.com>
* check if blockExplorer exists in rpcPrefs * revert unnecessary change
Sync `master` with `develop`
This updates `eth-lattice-keyring`, which itself updates `gridplus-sdk`. These changes are backwards compatible but do unlock functionality in Lattice firmware v0.13.2 Underlying Changes: * `gridplus-sdk`: GridPlus/gridplus-sdk@v0.9.2...v0.9.7 * `eth-lattice-keyring`: GridPlus/eth-lattice-keyring@v0.4.0...v0.4.9
* remove infura project_id from networks form field
In feature branches, it is very common to make ancillary changes to translation files. For instance, a key may be no longer in use, so in order to satisfy CI, it must be removed across all translation files. These changes can make reviewing PRs difficult, as one has to scroll past them in order to find the more impactful changes. To address this problem, this commit updates `.gitattributes` to suppress diffs involving translation files by default. A tradeoff to this change is that it will make it more difficult to review PRs whose sole purpose is to update translations. That said, for small PRs submitted by contributors, it is likely that only one or two translation files will be updated, so it is easy to expand the diffs for such files. For larger PRs such as those submitted by Crowdin, these diffs are so large that GitHub ends up suppressing them anyway. If this ends up being bothersome, one way to work around this is to use the [Refined GitHub][1] browser extension, which allows you to Alt/Opt-click on a single "Load diff" message to load all diffs which are currently suppressed. So at most this would take one click to solve. [Refined GitHub]: https://github.com/refined-github/refined-github
* Fixes in EIP-1559 V2 implementation * Adding check for transaction.id in useTransactionEventFragment hook * Update ui/components/app/advanced-gas-fee-popover/advanced-gas-fee-gas-limit/advanced-gas-fee-gas-limit.js Co-authored-by: Alex Donesky <adonesky@gmail.com> * fix * fix * fix * fix * fix * fix build Co-authored-by: Dan J Miller <danjm.com@gmail.com> Co-authored-by: Alex Donesky <adonesky@gmail.com>
* Correct connection language Fixes #13604 Does not initiate transactions, but suggests them. * Update app/_locales/en/messages.json
* Fix: Insufficient number of substitutions for key "stxSuccessDescription" * Only calculate "approvalGas" if the "approvalNeeded" param is truthy in a quote * "Swap from" has to be set to enable "Review Swap", set a default token for "Swap from" * Fix: Unable to find value of key "undefined" for locale * Use array destructuring
Does anyone know when this PR will be merged and go live to production? Currently this is preventing users from being able to take specific actions on Opensea with their Trezor (ie. listing, selling, bidding, etc) |
After landing on Swap, a disclaimer of Smart Transactions appear, and an error on devTools shows the following: “invalid prop ‘type’ of value ‘ul’” supplied to ‘Typography’ After enabling Smart Transactions, an error on devTools shows the following: “invalid prop ‘smartTransactionsOptInSatus’ of type ‘boolean supplied to ‘SlippageButtons’ Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Builds ready [47661fc]Page Load Metrics (1064 ± 16 ms)
highlights:storybook
|
Builds ready [532cf54]Page Load Metrics (1363 ± 81 ms)
highlights:storybook
|
Builds ready [98b3da3]Page Load Metrics (1100 ± 23 ms)
highlights:storybook
|
…" in Permissions Modal (#13833) * ConnectedAccountsPermissions: convert to FC * permissions: add usePermissionsDescriptions - fix ConnectedAccountsPermissions eth_accounts i18n * ConnectedAccountsPermissions: rm .component from path * ConnectedAccountsPermissions: fix toggleExpanded ensure we change previous state value Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Builds ready [34bf555]Page Load Metrics (1147 ± 32 ms)
highlights:storybook
|
* persist stx controller state * Pass STX controller state as the 3rd param * Trigger Build Co-authored-by: Dan Miller <danjm.com@gmail.com>
Builds ready [d17d7f2]Page Load Metrics (1179 ± 41 ms)
highlights:storybook
|
PeterYinusa
approved these changes
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 🚀
[10.11.0]
Added
Changed
Fixed