Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v10.11.0 RC #13706

Merged
merged 81 commits into from
Mar 5, 2022
Merged

Version v10.11.0 RC #13706

merged 81 commits into from
Mar 5, 2022

Conversation

metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Feb 21, 2022

📦 🚀

[10.11.0]

Added

  • Swaps: Add support for Smart Transactions on Mainnet and Rinkeby (#12676)
  • Add "Token details" page (#13216)
  • Add icons to sections in settings (#12920)

Changed

  • Swaps: Change language "Quote X of Y" to "Fetching quote X of Y" (#13663)
  • Update preferred account identicon selection UI (#13408)
  • Include transactions from all networks in state logs (#13599)
  • Update accounts connection language (#13605)
  • Style updates for setting page in full screen mode (#13569)
  • Add currency symbol validation in the add network form (#12431)

Fixed

  • Ensure pre-selected account on connect screen is visible in list (#13621)
  • Do not allow transaction creation with gas limit below minimum (#13574)
  • Fix network editing error when no block explorer is provided (#13527)
  • Swaps: Fix BigNumber error when submitting quote (#13555)

Gudahtt and others added 30 commits February 3, 2022 10:36
The form used for creating a vault on the "Import" page of onboarding
and on the "Restore vault" page is nearly identical, yet the
implementation is totally separate. It has now been extracted to a
separate component, consolidating the two implementations.

There is a "terms of use" checkbox on the import page that isn't on the
restore vault page, so that part has been made optional. The "submit"
button text differs between the two uses as well, so that is
customizable.

There are slight styling differences between the old and new versions
of this form. The fonts and spacing are all using our new standard
design system guidelines, and we're using our standard checkbox now as
well. The spacing and font sizes were chosen somewhat arbitrarily by me
to resemble the old styles, so please feel free to suggest changes if
you think they can be improved upon.

There are some slight copy changes to the "Restore vault" page as well;
the placeholder text and the label for the "Secret Recovery Phrase"
field now matches the "Import" page copy.
* Update personal-sign.spec.js

* Update signature-request.spec.js

* Add tests for eth_signTypedData and eth_signTypedData_v3 methods

* Lint

* Verify message

* Verify message

* Add test for eth_sign method
* validate ticker symbol in add/edit network form
* Add metamaskbot GH_USERNAME and GH_EMAIL to env

* add additional config for token, github_user_name, github_user_email

* delete

* delete token

* add GITHUB_ACTOR

Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
… address' in permissions/specifications (#13521)

* captureKeyringTypesWithMissingIdentities() when 'Missing identity for address' in permissions/specifications

* Fix unit tests
* updated settings page

removed unused messages

fixed width

moved icons into one folder

review comments update

removed unused strings

renamed components

removed class

added prop

updated e2e test

e2e

extracted icons

* locales fix

* update

* margin-inline
* Do not call `decimalToHex` for `minimumGasLimit`, which is already in hex

* Add `0x` prefix when returning a gas estimate

* Fix UTs

Co-authored-by: Dan J Miller <danjm.com@gmail.com>
* update test-dapp to 5.0.0

* Update edit-gas-fee.spec.js

* Lint

* Update send-eth.spec.js

* Update signature-request.spec.js

* typo

Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* check if blockExplorer exists in rpcPrefs

* revert unnecessary change
This updates `eth-lattice-keyring`, which itself updates `gridplus-sdk`.
These changes are backwards compatible but do unlock functionality in
Lattice firmware v0.13.2

Underlying Changes:
* `gridplus-sdk`: GridPlus/gridplus-sdk@v0.9.2...v0.9.7
* `eth-lattice-keyring`: GridPlus/eth-lattice-keyring@v0.4.0...v0.4.9
* remove infura project_id from networks form field
In feature branches, it is very common to make ancillary changes to
translation files. For instance, a key may be no longer in use, so in
order to satisfy CI, it must be removed across all translation files.
These changes can make reviewing PRs difficult, as one has to scroll
past them in order to find the more impactful changes. To address this
problem, this commit updates `.gitattributes` to suppress diffs
involving translation files by default.

A tradeoff to this change is that it will make it more difficult to
review PRs whose sole purpose is to update translations. That said, for
small PRs submitted by contributors, it is likely that only one or two
translation files will be updated, so it is easy to expand the diffs for
such files. For larger PRs such as those submitted by Crowdin, these
diffs are so large that GitHub ends up suppressing them anyway.

If this ends up being bothersome, one way to work around this is to use
the [Refined GitHub][1] browser extension, which allows you to
Alt/Opt-click on a single "Load diff" message to load all diffs which
are currently suppressed. So at most this would take one click to solve.

[Refined GitHub]: https://github.com/refined-github/refined-github
* Fixes in EIP-1559 V2 implementation

* Adding check for transaction.id in useTransactionEventFragment hook

* Update ui/components/app/advanced-gas-fee-popover/advanced-gas-fee-gas-limit/advanced-gas-fee-gas-limit.js

Co-authored-by: Alex Donesky <adonesky@gmail.com>

* fix

* fix

* fix

* fix

* fix

* fix build

Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* Correct connection language

Fixes #13604

Does not initiate transactions, but suggests them.

* Update app/_locales/en/messages.json
ryanml and others added 6 commits February 22, 2022 19:49
* Fix: Insufficient number of substitutions for key "stxSuccessDescription"

* Only calculate "approvalGas" if the "approvalNeeded" param is truthy in a quote

* "Swap from" has to be set to enable "Review Swap", set a default token for "Swap from"

* Fix: Unable to find value of key "undefined" for locale

* Use array destructuring
@ryanml ryanml removed the request for review from digiwand February 23, 2022 23:38
@metamaskbot
Copy link
Collaborator Author

Builds ready [7af8570]
Page Load Metrics (1040 ± 13 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint621073574455219
domContentLoaded1001108610382713
load1005108610402713
domInteractive1001108610382713

highlights:

storybook

@abakshi11
Copy link

Does anyone know when this PR will be merged and go live to production? Currently this is preventing users from being able to take specific actions on Opensea with their Trezor (ie. listing, selling, bidding, etc)

ryanml and others added 4 commits March 2, 2022 09:04
After landing on Swap, a disclaimer of Smart Transactions appear, and an error on devTools shows the following: “invalid prop ‘type’ of value ‘ul’” supplied to ‘Typography’
    After enabling Smart Transactions, an error on devTools shows the following: “invalid prop ‘smartTransactionsOptInSatus’ of type ‘boolean supplied to ‘SlippageButtons’

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@metamaskbot
Copy link
Collaborator Author

Builds ready [47661fc]
Page Load Metrics (1064 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641113381443213
domContentLoaded1020113810613416
load1024113810643316
domInteractive1020113810613416

highlights:

storybook

@metamaskbot
Copy link
Collaborator Author

Builds ready [532cf54]
Page Load Metrics (1363 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint781399799493237
domContentLoaded11041743136216880
load11041743136316881
domInteractive11041743136216880

highlights:

storybook

@metamaskbot
Copy link
Collaborator Author

Builds ready [98b3da3]
Page Load Metrics (1100 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641201640514247
domContentLoaded1020120610965124
load1032120611004923
domInteractive1020120610965124

highlights:

storybook

…" in Permissions Modal (#13833)

* ConnectedAccountsPermissions: convert to FC

* permissions: add usePermissionsDescriptions
- fix ConnectedAccountsPermissions eth_accounts i18n

* ConnectedAccountsPermissions: rm .component
from path

* ConnectedAccountsPermissions: fix toggleExpanded

ensure we change previous state value

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@metamaskbot
Copy link
Collaborator Author

Builds ready [34bf555]
Page Load Metrics (1147 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641281679519249
domContentLoaded1035128511437034
load1044128511476832
domInteractive1035128511437034

highlights:

storybook

* persist stx controller state

* Pass STX controller state as the 3rd param

* Trigger Build

Co-authored-by: Dan Miller <danjm.com@gmail.com>
@metamaskbot
Copy link
Collaborator Author

Builds ready [d17d7f2]
Page Load Metrics (1179 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691321593515247
domContentLoaded1057139411748742
load1066139411798641
domInteractive1057139411748742

highlights:

storybook

@ryanml ryanml merged commit c86a642 into master Mar 5, 2022
@ryanml ryanml deleted the Version-v10.11.0 branch March 5, 2022 01:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet